Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHS-5878: Fix 3rd-level items in shortcut menu #1661

Merged
merged 2 commits into from
Oct 22, 2024
Merged

SHS-5878: Fix 3rd-level items in shortcut menu #1661

merged 2 commits into from
Oct 22, 2024

Conversation

mariannuar
Copy link
Collaborator

@mariannuar mariannuar commented Oct 16, 2024 •
edited by ahughes3
Loading

READY FOR REVIEW

Summary

Fix 3rd-level items in shortcut menu

Need Review By (Date)

10/23

Urgency

medium

Steps to Test

  1. In any site, go to this path: /admin/config/user-interface/shortcut/manage/default/customize or go to this site that already has a 3rd-level item in Shortcut > Site Actions > Page Not found Report > Third level item
  2. Add a shortcut item
  3. Move it (it should a 3rd-level item in the menu)
  4. Verify that if there are 3rd-level items, they can be clicked

PR Checklist

@ahughes3 ahughes3 temporarily deployed to Tugboat October 16, 2024 17:42 Destroyed
@mariannuar mariannuar self-assigned this Oct 16, 2024
@mariannuar mariannuar requested a review from cienvaras October 16, 2024 17:56
@cienvaras cienvaras changed the base branch from develop to 11.4.1-release October 17, 2024 15:14
@ahughes3 ahughes3 temporarily deployed to Tugboat October 17, 2024 15:19 Destroyed
cienvaras
cienvaras approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar LGTM! 🚀

@ahughes3 Ready for you to review.

@cienvaras cienvaras assigned ahughes3 and unassigned mariannuar Oct 17, 2024
@cienvaras cienvaras requested a review from ahughes3 October 17, 2024 23:13
ahughes3
ahughes3 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@ahughes3 ahughes3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ahughes3 ahughes3 requested a review from joegl October 21, 2024 21:06
@ahughes3 ahughes3 assigned joegl and unassigned ahughes3 Oct 21, 2024
@joegl joegl changed the title SHS-5878: Shortcut Downloads menu broken (CEAS, others?) SHS-5878: Fix 3rd-level items in shortcut menu Oct 22, 2024
@joegl joegl merged commit 1d8e03e into 11.4.1-release Oct 22, 2024
17 checks passed
@joegl joegl deleted the shs-5878-shortcut-download-menu branch October 22, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahughes3 ahughes3 ahughes3 approved these changes

@cienvaras cienvaras cienvaras approved these changes

@joegl joegl joegl approved these changes

Assignees

@joegl joegl

Labels
Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mariannuar @ahughes3 @cienvaras @joegl